diff options
| author | Joas Antonio dos Santos <joasantonio108@gmail.com> | 2026-11-02 13:03:56 +0000 |
|---|---|---|
| committer | Andrew Morton <akpm@linux-foundation.org> | 2026-11-09 22:44:30 -0800 |
| commit | ccf8bda05b19dc144bc7051936b08573476499ee (patch) | |
| tree | e225415a57e63316ee6c6abf2bce57137290cc83 /include/linux | |
| parent | c8c47f4072bdcff783cedd5a8565242a212af058 (diff) | |
hugetlbfs: move hugetlbfs_free_inode tracepoint to ->destroy_inode()
hugetlbfs_free_inode() calls trace_hugetlbfs_free_inode(), and the
hugetlbfs__inode event class records inode->i_sb->s_dev. ->free_inode()
runs from an RCU callback (destroy_inode() queues i_callback() with
call_rcu()), and Documentation/filesystems/porting.rst says that this
callback "is *NOT* ordered wrt superblock destruction; as the matter of
fact, the superblock and all associated structures might be already gone".
put_super() frees the superblock with call_rcu() followed by a workqueue
item (destroy_super_rcu() -> destroy_super_work()). syzbot hit this with
the event enabled:
BUG: KASAN: slab-use-after-free in trace_event_raw_event_hugetlbfs__inode+0x45b/0x4c0 include/trace/events/hugetlbfs.h:36
Read of size 4 at addr ffff888038850010 by task syz-executor952/6134
hugetlbfs_free_inode+0x15e/0x1f0 fs/hugetlbfs/inode.c:1182
i_callback+0x46/0x80 fs/inode.c:317
rcu_do_batch kernel/rcu/tree.c:2650 [inline]
rcu_core+0x5f0/0x1220 kernel/rcu/tree.c:2919
Allocated by task 6134:
alloc_super fs/super.c:326 [inline]
sget_fc+0x1ba/0x1f60 fs/super.c:874
hugetlbfs_get_tree+0x1e7/0x2b0 fs/hugetlbfs/inode.c:1431
Freed by task 855:
kfree+0x22b/0x6d0 mm/slub.c:6923
process_one_work+0xac7/0x1b10 kernel/workqueue.c:3495
Emit the event from hugetlbfs_destroy_inode() instead. destroy_inode()
calls ->destroy_inode() synchronously, before it queues the RCU callback,
while the superblock is still alive; hugetlbfs_destroy_inode() already
dereferences inode->i_sb there. ->free_inode() is left with only the
kmem_cache_free().
Since the event no longer fires from ->free_inode(), rename it to
hugetlbfs_destroy_inode so that its name matches where it is emitted, as
suggested by David and Muchun.
Found by syzbot; analysed and tested with the syzbot C reproducer on an
arm64 KASAN kernel.
Link: https://lore.kernel.org/20261102-b4-hugetlbfs-trace-v4-1-72371825bb5e@gmail.com
Fixes: 014ad7c42a69 ("hugetlbfs: use tracepoints in hugetlbfs functions.")
Signed-off-by: Joas Antonio dos Santos <joasantonio108@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reported-by: <syzbot+91e1fc35f51774c479b2@syzkaller.appspotmail.com>
Closes: https://lore.kernel.org/all/6ae27525.5451848c.f7707.0001.GAE@google.com/
Suggested-by: David Hildenbrand <david@kernel.org>
Suggested-by: Muchun Song <muchun.song@linux.dev>
Reviewed-by: Muchun Song <muchun.song@linux.dev>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Hongbo Li <lihongbo22@huawei.com>
Cc: <stable@vger.kernel.org>
Diffstat (limited to 'include/linux')
0 files changed, 0 insertions, 0 deletions
