summaryrefslogtreecommitdiff
path: root/include/linux
diff options
context:
space:
mode:
authorJustin Chen <justin.chen@broadcom.com>2026-09-29 13:34:00 -0700
committerJakub Kicinski <kuba@kernel.org>2026-10-06 18:41:37 -0700
commitea311fea32363f331ec091e1287727ce972c7ddc (patch)
treefbfae803e3a67bee6f48a266f0566bf5f679cdc6 /include/linux
parent81d705e38978656f7f2d643faef4faf3d90af770 (diff)
net: bcmasp: fix lost TX wakeup race with lockless queue API
netif_stop_queue() in bcmasp_xmit() raced with netif_wake_queue() in bcmasp_tx_poll(): a reclaim landing between the ring-full check and the stop call left the queue stopped despite free descriptors, hanging TX until timeout. Switch to netif_txq_maybe_stop()/netif_txq_completed_wake() (the lockless TX queue API, which also brings in BQL), replace tx_spb_ring_full() with a live bcmasp_tx_avail() count. This issue was discovered using LLM and is only theoretical. Tested on a BCM74110 that no regressions were encountered. Cc: stable+noautosel@kernel.org # LLM report + LLM fix, not seen in real life Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller") Signed-off-by: Justin Chen <justin.chen@broadcom.com> Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Link: https://patch.msgid.link/20260929203400.1588868-1-justin.chen@broadcom.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/linux')
0 files changed, 0 insertions, 0 deletions