diff options
| author | Ben Hutchings <bhutchings@solarflare.com> | 2013-07-04 23:48:46 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-07-28 16:29:53 -0700 |
| commit | 1c6d3d1d21e522c9722cd6bdfd57afb171786028 (patch) | |
| tree | bd6e918aa0918f5f3d24c1da24b5791396052035 /include | |
| parent | c3a5491228f90fd82e67b7ccd2fcbaf984d44c07 (diff) | |
sfc: Fix memory leak when discarding scattered packets
[ Upstream commit 734d4e159b283a4ae4d007b7e7a91d84398ccb92 ]
Commit 2768935a4660 ('sfc: reuse pages to avoid DMA mapping/unmapping
costs') did not fully take account of DMA scattering which was
introduced immediately before. If a received packet is invalid and
must be discarded, we only drop a reference to the first buffer's
page, but we need to drop a reference for each buffer the packet
used.
I think this bug was missed partly because efx_recycle_rx_buffers()
was not renamed and so no longer does what its name says. It does not
change the state of buffers, but only prepares the underlying pages
for recycling. Rename it accordingly.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions