summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorGuangshuo Li <lgs201920130244@gmail.com>2026-05-14 19:38:34 +0800
committerLeon Romanovsky <leon@kernel.org>2026-05-19 19:32:48 -0300
commit5b74373390113fba798a76b483837029ab010fef (patch)
tree429f0b7e9a684d32a01ff9e065a755e9383f24b2 /include
parentc9a40f6531b81baa9619bcc2697ff86896afcce7 (diff)
RDMA/rtrs: Fix use-after-free in path file creation cleanup
In the error path of rtrs_srv_create_path_files(), the sysfs root folders may already have been created and srv_path->kobj may already have been initialized. If a later step fails, the cleanup currently calls kobject_put(&srv_path->kobj) before rtrs_srv_destroy_once_sysfs_root_folders(srv_path). kobject_put() may drop the last reference to srv_path->kobj and invoke the release callback, rtrs_srv_release(), which frees srv_path. The following call to rtrs_srv_destroy_once_sysfs_root_folders(srv_path) then dereferences srv_path internally to access srv_path->srv, resulting in a use-after-free. This failure path is reached before rtrs_srv_create_path_files() returns success, so the successful-path lifetime handling is not involved. Fix this by destroying the sysfs root folders before calling kobject_put(&srv_path->kobj), so srv_path is still valid while the helper accesses it. This issue was found by a static analysis tool I am developing. Fixes: ae4c81644e91 ("RDMA/rtrs-srv: Rename rtrs_srv_sess to rtrs_srv_path") Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com> Link: https://patch.msgid.link/20260514113834.865530-1-lgs201920130244@gmail.com Signed-off-by: Leon Romanovsky <leon@kernel.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions