summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorBharath SM <bharathsm@microsoft.com>2026-03-09 16:00:49 +0530
committerSteve French <stfrench@microsoft.com>2026-03-10 17:22:03 -0500
commitd78840a6a38d312dc1a51a65317bb67e46f0b929 (patch)
tree3bdc32610f6df5ab6dec694f9a564e51729166e9 /include
parentfae11330dc0642065568d6c0045322293fe59bc6 (diff)
smb: client: fix in-place encryption corruption in SMB2_write()
SMB2_write() places write payload in iov[1..n] as part of rq_iov. smb3_init_transform_rq() pointer-shares rq_iov, so crypt_message() encrypts iov[1] in-place, replacing the original plaintext with ciphertext. On a replayable error, the retry sends the same iov[1] which now contains ciphertext instead of the original data, resulting in corruption. The corruption is most likely to be observed when connections are unstable, as reconnects trigger write retries that re-send the already-encrypted data. This affects SFU mknod, MF symlinks, etc. On kernels before 6.10 (prior to the netfs conversion), sync writes also used this path and were similarly affected. The async write path wasn't unaffected as it uses rq_iter which gets deep-copied. Fix by moving the write payload into rq_iter via iov_iter_kvec(), so smb3_init_transform_rq() deep-copies it before encryption. Cc: stable@vger.kernel.org #6.3+ Acked-by: Henrique Carvalho <henrique.carvalho@suse.com> Acked-by: Shyam Prasad N <sprasad@microsoft.com> Acked-by: Paulo Alcantara (Red Hat) <pc@manguebit.org> Signed-off-by: Bharath SM <bharathsm@microsoft.com> Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions