summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorGuangshuo Li <lgs201920130244@gmail.com>2026-05-05 23:02:56 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2026-05-22 12:19:02 +0200
commitf74c8696f14149d5e43cc28b015326a759c48f00 (patch)
tree3e30a2a4d715824c4677d8e23ea0a1d2e1ec8e3b /include
parentf6d8fea9e3953151a4adb4f603503dc3dc9c69da (diff)
uio: uio_pci_generic_sva: fix double free of devm_kzalloc() memory
uio_pci_sva allocates struct uio_pci_sva_dev with devm_kzalloc() in probe(), but then calls kfree(udev) both on the probe() error path (label out_free) and again in remove(). Because devm_kzalloc() allocations are devres-managed and are freed automatically when the device is detached (including after a failing probe() and during driver unbind), the explicit kfree() can lead to a double free. If probe() fails after devm_kzalloc(), the error path frees udev and devres cleanup will free it again when the core unwinds the partially bound device. On normal driver removal, remove() frees udev and devres will free it again when the device is detached. This issue was identified by a static analysis tool I developed and confirmed by manual review. Fix by removing the manual kfree() calls and dropping the now-unused label. Fixes: 3397c3cd859a2 ("uio: Add SVA support for PCI devices via uio_pci_generic_sva.c") Cc: stable <stable@kernel.org> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com> Link: https://patch.msgid.link/20260505150256.614071-1-lgs201920130244@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions