summaryrefslogtreecommitdiff
path: root/kernel/debug/debug_core.c
diff options
context:
space:
mode:
authorJiri Slaby (SUSE) <jirislaby@kernel.org>2026-11-03 12:16:37 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2026-11-03 13:25:08 +0100
commit0353b51965883cf70dad162908e07395f242000f (patch)
tree3fa4dd636ffc99b496ab7a326a9bba81bafc5af9 /kernel/debug/debug_core.c
parent6628e7d4c6b25c8d18f1345e3a20d21829aae7e4 (diff)
serial: 8250_exar: check priv->gpio properly
priv->gpio is set by platform_device_register_full(), which returns error-encoded pointers on failure, not NULL. Sashiko reported: > Does __xr17v35x_register_gpio() return an ERR_PTR if > platform_device_register_full() fails? > > If it does, we might be storing an error pointer directly into > priv->gpio in xr17v35x_register_gpio() without validating it with > IS_ERR(). Because the error is ignored, the device probe > successfully continues. Before commit 1145d1a0703f ("serial: 8250_exar: use platform_device_register_full()"), __xr17v35x_register_gpio() returned NULL on any failure (platform_device_alloc(), device_add_software_node() or platform_device_add() failing were all turned into a NULL return). The plain truthy check in xr17v35x_unregister_gpio() matched that convention. That commit switched registration to platform_device_register_full(), which reports failure as an ERR_PTR() instead of NULL, but the unregister check was never updated to match. As a result, a failed registration left an error pointer in priv->gpio, and unbind would tear it down as if it were a real platform_device, dereferencing the encoded error value in device_remove_software_node() and platform_device_unregister(). Use IS_ERR_OR_NULL() instead, so both the unset (non-EXAR vendor, priv->gpio never assigned) and failed-registration (ERR_PTR) cases are skipped. Fixes: 1145d1a0703f ("serial: 8250_exar: use platform_device_register_full()") Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> Cc: stable@vger.kernel.org Assisted-by: LLM Link: https://lore.kernel.org/all/sashiko-outbox-170895@kernel.org/ Link: https://patch.msgid.link/28c09cf858795491f66667781bf79fb6a603f159.1793704520.git.jirislaby@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/debug/debug_core.c')
0 files changed, 0 insertions, 0 deletions