summaryrefslogtreecommitdiff
path: root/kernel/debug/debug_core.c
diff options
context:
space:
mode:
authorMarek Szyprowski <m.szyprowski@samsung.com>2026-11-10 00:08:29 +0100
committerMarek Szyprowski <m.szyprowski@samsung.com>2026-11-16 11:29:54 +0100
commit14866e632fa48a0b4c385ab0121526575eb8f88c (patch)
treec478e2b58e3dcd78804a6c11095f9f7973033bcc /kernel/debug/debug_core.c
parent7d4a177d0d9bc0ca04caec9293ccb902a853cc47 (diff)
dma-pool: decrypt pages before creating the shared remap
atomic_pool_expand() creates the pgprot_decrypted() remap of the pool pages before calling set_memory_decrypted() on them. The error path when gen_pool_add_virt() fails does the reverse: it re-encrypts the pages and only then tears down the decrypted remap. In both cases there is a window where a decrypted (shared) kernel mapping points at a page that is still private, i.e. encrypted, to the guest. dma_direct_alloc() gets this right: it converts the pages first, then creates the remap, and on error removes the remap before re-encrypting. Do the same in atomic_pool_expand(). The pages are now converted before arch_dma_prep_coherent() and the remap, and the error path unwinds in reverse order. If set_memory_decrypted() fails, the encryption state of the pages is unknown (the conversion may have partially succeeded), so they must not be returned to the page allocator or CMA and are intentionally leaked, as before. No remap exists at that point any more, so nothing else needs to be undone. Add a comment explaining this. Closes: https://sashiko.dev/#/bug/linux-9212d9b5-4a56-43e2-bc00-6e69b724078b Fixes: 76a19940bd62 ("dma-direct: atomic allocations must come from atomic coherent pools") Reviewed-by: Aneesh Kumar K.V (Arm) <aneesh.kumar@kernel.org> Link: https://lore.kernel.org/r/20261109230830.1707975-1-m.szyprowski@samsung.com Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Diffstat (limited to 'kernel/debug/debug_core.c')
0 files changed, 0 insertions, 0 deletions