diff options
| author | Josef Bacik <josef@toxicpanda.com> | 2026-10-27 12:06:28 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-11-03 13:28:52 +0100 |
| commit | 84da8238f7bd3025fc16da32c4cd9992c95a783b (patch) | |
| tree | 076ab24a1205d4f9fae174ad9624e77a54a79035 /kernel/debug/debug_core.c | |
| parent | 5d1d814408c1c8e797031eac8ddd40de1a9e8e93 (diff) | |
serial: core: respect runtime PM when sending x_char
__uart_start() calls the start_tx operation only if the port is runtime
active. Otherwise it asks for a resume, and
serial_port_runtime_resume() starts the transmitter.
uart_send_xchar() calls start_tx at once, under the port lock, whatever
the state of the device. With 8250_omap, serial8250_start_tx() then
calls pm_runtime_get_sync() for a suspended device: that sleeps, and
omap8250_runtime_resume() takes the port lock again. A tcflow(TCIOFF)
on an idle port is enough, if autosuspend has been enabled. It was
allowed as long as that driver used pm_runtime_irq_safe().
Share the part of __uart_start() that deals with runtime PM. A stopped
transmission still does not hold up an XON or XOFF character. Let a
pending x_char count as work for serial_port_runtime_resume(), and keep
the port from being suspended with it.
Fixes: 8700a7ea5519 ("serial: 8250_omap: Drop pm_runtime_irq_safe()")
Cc: stable <stable@kernel.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Cc: Johan Hovold <johan@kernel.org>
Cc: Karl Mehltretter <kmehltretter@gmail.com>
Cc: John Ogness <john.ogness@linutronix.de>
Cc: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Tony Lindgren <tony.lindgren@linux.intel.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patch.msgid.link/20261027-tty-llm-v1-2-99b0202ae546@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/debug/debug_core.c')
0 files changed, 0 insertions, 0 deletions
