summaryrefslogtreecommitdiff
path: root/kernel/debug/debug_core.c
diff options
context:
space:
mode:
authorNathan Chancellor <nathan@kernel.org>2026-11-14 21:26:10 -0700
committerJoel Fernandes <jfern@kernel.org>2026-11-15 18:52:04 -0500
commitc3f98ff6309a29979e1867bc3c9d4172755ca122 (patch)
tree33732fcb6f8ed711ad47955a95da3aff154f96f3 /kernel/debug/debug_core.c
parent38828d44f31e4366b2963d5786d06d3358e8ae58 (diff)
rcu/nocb: Avoid unsequenced accesses to jiffies in show_rcu_nocb_state()
After a recent improvement in clang to warn on unsequenced accesses to volatile variables [1], an instance appears in show_rcu_nocb_state(), which can break the build with CONFIG_WERROR=y / W=e: In file included from kernel/rcu/tree.c:5123: kernel/rcu/tree_nocb.h:1651:3: error: unsequenced accesses to volatile qualified 'jiffies' [-Werror,-Wunsequenced] 1650 | jiffies - rdp->nocb_bypass_first, | ~~~~~~~ 1651 | jiffies - rdp->nocb_nobypass_last, | ^ Per C11 5.1.2.3.2, accessing a volatile object is a side effect. Per C11 6.5.2, unsequenced side effects on the same scalar object are undefined behavior. Per C11 6.5.2.2.10/12, the evaluation of arguments in a function call is indeterminately sequenced, meaning any side effects in the arguments are unsequenced. Add a local variable to hold the value of jiffies before the function call so that there are no unsequenced side effects, clearing up the warning. Cc: stable@vger.kernel.org Fixes: f7a81b12d6af ("rcu/nocb: Print no-CBs diagnostics when rcutorture writer unduly delayed") Closes: https://github.com/ClangBuiltLinux/linux/issues/2192 Link: https://github.com/llvm/llvm-project/commit/955715460eaf9188c241c74750637fc82dfcc423 [1] Signed-off-by: Nathan Chancellor <nathan@kernel.org> Reviewed-by: Joel Fernandes <jfern@kernel.org> Signed-off-by: Joel Fernandes <jfern@kernel.org>
Diffstat (limited to 'kernel/debug/debug_core.c')
0 files changed, 0 insertions, 0 deletions