diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2026-03-22 09:12:33 -0700 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2026-03-25 13:32:37 -0700 |
| commit | 754bd2b4a084b90b5e7b630e1f423061a9b9b761 (patch) | |
| tree | 6b5f585d8743eb88372ecd2d63e505877b4df4b1 /kernel/locking | |
| parent | cd658475e7694d58e1c40dabc1dacf8431ccedb2 (diff) | |
hwmon: (pmbus/core) Protect regulator operations with mutex
The regulator operations pmbus_regulator_get_voltage(),
pmbus_regulator_set_voltage(), and pmbus_regulator_list_voltage()
access PMBus registers and shared data but were not protected by
the update_lock mutex. This could lead to race conditions.
However, adding mutex protection directly to these functions causes
a deadlock because pmbus_regulator_notify() (which calls
regulator_notifier_call_chain()) is often called with the mutex
already held (e.g., from pmbus_fault_handler()). If a regulator
callback then calls one of the now-protected voltage functions,
it will attempt to acquire the same mutex.
Rework pmbus_regulator_notify() to utilize a worker function to
send notifications outside of the mutex protection. Events are
stored as atomics in a per-page bitmask and processed by the worker.
Initialize the worker and its associated data during regulator
registration, and ensure it is cancelled on device removal using
devm_add_action_or_reset().
While at it, remove the unnecessary include of linux/of.h.
Cc: Sanman Pradhan <psanman@juniper.net>
Fixes: ddbb4db4ced1b ("hwmon: (pmbus) Add regulator support")
Reviewed-by: Sanman Pradhan <psanman@juniper.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'kernel/locking')
0 files changed, 0 insertions, 0 deletions
