diff options
| author | Zqiang <qiang.zhang@linux.dev> | 2025-12-22 19:53:18 +0800 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2025-12-22 17:55:41 -1000 |
| commit | 714d81423e9948fcdb4e3eb948ec188ffd2ac131 (patch) | |
| tree | dc19472f2e647cdca67c0f3af0d7190d4a7f0ae7 /kernel | |
| parent | ccaeeb585c7c2a0ac67ee1af9acb4d1411dc409e (diff) | |
sched_ext: Avoid multiple irq_work_queue() calls in destroy_dsq()
llist_add() returns true only when adding to an empty list, which indicates
that no IRQ work is currently queued or running. Therefore, we only need to
call irq_work_queue() when llist_add() returns true, to avoid unnecessarily
re-queueing IRQ work that is already pending or executing.
Signed-off-by: Zqiang <qiang.zhang@linux.dev>
Reviewed-by: Andrea Righi <arighi@nvidia.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/sched/ext.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 8f6d8d7f895c..136b01950a62 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -3439,8 +3439,8 @@ static void destroy_dsq(struct scx_sched *sch, u64 dsq_id) * operations inside scheduler locks. */ dsq->id = SCX_DSQ_INVALID; - llist_add(&dsq->free_node, &dsqs_to_free); - irq_work_queue(&free_dsq_irq_work); + if (llist_add(&dsq->free_node, &dsqs_to_free)) + irq_work_queue(&free_dsq_irq_work); out_unlock_dsq: raw_spin_unlock_irqrestore(&dsq->lock, flags); |