diff options
| author | Shardul Bankar <shardulsb08@gmail.com> | 2025-10-21 13:38:46 +0530 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2025-10-21 09:39:05 -0700 |
| commit | 96d31dff3fa428845aad05c5ae3a1593f6e17add (patch) | |
| tree | 97403c7a4c80ef34f26a2d8af5128092f0c19e91 /kernel | |
| parent | 04a899573fb87273a656f178b5f920c505f68875 (diff) | |
bpf: Clarify get_outer_instance() handling in propagate_to_outer_instance()
propagate_to_outer_instance() calls get_outer_instance() and uses the
returned pointer to reset and commit stack write marks. Under normal
conditions, update_instance() guarantees that an outer instance exists,
so get_outer_instance() cannot return an ERR_PTR.
However, explicitly checking for IS_ERR(outer_instance) makes this code
more robust and self-documenting. It reduces cognitive load when reading
the control flow and silences potential false-positive reports from
static analysis or automated tooling.
No functional change intended.
Signed-off-by: Shardul Bankar <shardulsb08@gmail.com>
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/r/20251021080849.860072-1-shardulsb08@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/bpf/liveness.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/kernel/bpf/liveness.c b/kernel/bpf/liveness.c index 1e6538f59a78..baa742e6cbb6 100644 --- a/kernel/bpf/liveness.c +++ b/kernel/bpf/liveness.c @@ -524,6 +524,8 @@ static int propagate_to_outer_instance(struct bpf_verifier_env *env, this_subprog_start = callchain_subprog_start(callchain); outer_instance = get_outer_instance(env, instance); + if (IS_ERR(outer_instance)) + return PTR_ERR(outer_instance); callsite = callchain->callsites[callchain->curframe - 1]; reset_stack_write_marks(env, outer_instance, callsite); |