summaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorEnlin Mu <enlin.mu@linux.dev>2026-08-25 09:15:09 +0800
committerThomas Gleixner <tglx@kernel.org>2026-09-05 20:52:12 +0200
commita0e1fdb96578ea562a03c487f70673d228824d0a (patch)
tree6bda65dd46da6f567751262bf9611798f0070437 /kernel
parent94235414a0568f260b60b89ec584ff4829d5e8c9 (diff)
softirq: Remove redundant h->action from preempt_count mismatch error
When a preempt_count mismatch is detected in handle_softirqs(), the error message currently prints the softirq action handler (h->action). However, as Thomas Gleixner pointed out, the action handler for a given softirq vector is always a known, fixed function (e.g., run_timer_softirq for TIMER_SOFTIRQ). Printing it provides zero diagnostic value. The real issue typically lies in the functions invoked *within* that handler, not the handler entry point itself. Therefore, as suggested by Sebastian Andrzej Siewior, remove h->action from the print statement entirely to clean up the error message. Suggested-by: Thomas Gleixner <tglx@linutronix.de> Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Enlin Mu <enlin.mu@linux.dev> Signed-off-by: Thomas Gleixner <tglx@kernel.org> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Reviewed-by: Bradley Morgan <include@grrlz.net> Link: https://patch.msgid.link/20260825011509.8505-1-enlin.mu@linux.dev
Diffstat (limited to 'kernel')
-rw-r--r--kernel/softirq.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 7980a4a232f9..800d81c57302 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -645,8 +645,8 @@ restart:
h->action();
trace_softirq_exit(vec_nr);
if (unlikely(prev_count != preempt_count())) {
- pr_err("huh, entered softirq %u %s %p with preempt_count %08x, exited with %08x?\n",
- vec_nr, softirq_to_name[vec_nr], h->action,
+ pr_err("huh, entered softirq %u %s with preempt_count %08x, exited with %08x?\n",
+ vec_nr, softirq_to_name[vec_nr],
prev_count, preempt_count());
preempt_count_set(prev_count);
}