diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2025-10-30 12:44:21 +0100 |
|---|---|---|
| committer | Andrew Morton <akpm@linux-foundation.org> | 2025-11-20 14:03:40 -0800 |
| commit | f791dcc842cb1cb3777ae4122be4cd37624ad53d (patch) | |
| tree | 747fefa85d41b775df627fd0259f5da4befb635b /lib | |
| parent | eb72c4667f4567a7363f6e00d082d2ab32b6a03a (diff) | |
panic: sys_info: deduplicate local variable 'table; assignments
The both handlers use the local 'table' variable and assign the same data
to it, deduplicate that.
Link: https://lkml.kernel.org/r/20251030132007.3742368-6-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Feng Tang <feng.tang@linux.alibaba.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/sys_info.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/lib/sys_info.c b/lib/sys_info.c index eb5c1226bfc8..94526de8482b 100644 --- a/lib/sys_info.c +++ b/lib/sys_info.c @@ -63,12 +63,13 @@ int sysctl_sys_info_handler(const struct ctl_table *ro_table, int write, if (!names) return -ENOMEM; + table = *ro_table; + table.data = names; + table.maxlen = maxlen; + if (write) { int ret; - table = *ro_table; - table.data = names; - table.maxlen = maxlen; ret = proc_dostring(&table, write, buffer, lenp, ppos); if (ret) return ret; @@ -93,9 +94,6 @@ int sysctl_sys_info_handler(const struct ctl_table *ro_table, int write, } } - table = *ro_table; - table.data = names; - table.maxlen = maxlen; return proc_dostring(&table, write, buffer, lenp, ppos); } } |