diff options
| author | David S. Miller <davem@davemloft.net> | 2009-02-25 23:09:34 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-03-16 17:52:42 -0700 |
| commit | 21ef40e66f6186898ea4240b83a0f1c7424953d0 (patch) | |
| tree | f8cd7f28a308c33114c8988c0ce3638ec958158e /net/core/sock.c | |
| parent | a6fa7047cf5cb20353178e9b31c3105f13461b54 (diff) | |
net: Kill skb_truesize_check(), it only catches false-positives.
[ Upstream commit 92a0acce186cde8ead56c6915d9479773673ea1a ]
A long time ago we had bugs, primarily in TCP, where we would modify
skb->truesize (for TSO queue collapsing) in ways which would corrupt
the socket memory accounting.
skb_truesize_check() was added in order to try and catch this error
more systematically.
However this debugging check has morphed into a Frankenstein of sorts
and these days it does nothing other than catch false-positives.
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'net/core/sock.c')
| -rw-r--r-- | net/core/sock.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/core/sock.c b/net/core/sock.c index d9fa31b991f6..93adc5c9db9b 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -1136,7 +1136,6 @@ void sock_rfree(struct sk_buff *skb) { struct sock *sk = skb->sk; - skb_truesize_check(skb); atomic_sub(skb->truesize, &sk->sk_rmem_alloc); sk_mem_uncharge(skb->sk, skb->truesize); } |