summaryrefslogtreecommitdiff
path: root/net/ethtool/debug.c
diff options
context:
space:
mode:
authorMaxime Chevallier <maxime.chevallier@bootlin.com>2026-03-19 19:05:54 +0100
committerJakub Kicinski <kuba@kernel.org>2026-03-20 19:10:18 -0700
commit82a5852595f5afb36aebddcc3ebc2654ee4d3879 (patch)
tree657bc411f96ba9bf778ba82c6138d9d8a6c6f32a /net/ethtool/debug.c
parente783e40fb689381caca31e03d28c39e10c82e722 (diff)
net: ethtool: re-order local includes
Most local #include in the ethtool command handling is out of order, with either : #include "netlink.h" #include "common.h" or even : #include "netlink.h" #include "common.h" #include "bitset.h" One of the reasons is because bitset.h s lacking definitions for nlattr, netlink_ext_ack, ETH_GSTRING_LEN, and types such as u32, bool, etc. Make bitset.h standalone by including <linux/ethtool.h> for ETH_GSTRING_LEN, and <linux/netlink.h> for nlattr, netlink_ext_ack and the rest. While at it, take a pass on ethnl sources to re-order the local includes : - put them after the global includes - add a newline between global and local includes - alpha-sort the local includes One notable exception is the cmis.h include, that needs definitions from module_fw.h. Keep them in this order for now. Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> Link: https://patch.msgid.link/20260319180555.1531386-1-maxime.chevallier@bootlin.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ethtool/debug.c')
-rw-r--r--net/ethtool/debug.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ethtool/debug.c b/net/ethtool/debug.c
index 0b2dea56d461..6043916b440e 100644
--- a/net/ethtool/debug.c
+++ b/net/ethtool/debug.c
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0-only
-#include "netlink.h"
-#include "common.h"
#include "bitset.h"
+#include "common.h"
+#include "netlink.h"
struct debug_req_info {
struct ethnl_req_info base;