summaryrefslogtreecommitdiff
path: root/rust/kernel/alloc/allocator
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2026-10-27 09:03:51 -0700
committerGuenter Roeck <linux@roeck-us.net>2026-11-16 13:26:12 -0800
commit9208893253e755b3acf2bc1af038d5c973cc3b45 (patch)
tree7d499d97bb9ea38e0c35db9e0b3c01f3ed56c5e5 /rust/kernel/alloc/allocator
parent8cdd82238ed3f366850dd0bd1e130e09ba2ebc4c (diff)
watchdog: core: Cancel timer if cdev_device_add() fails
If misc_register() exposed the device to userspace before cdev_device_add() is called, a concurrent watchdog_open() could start the watchdog and arm wd_data->timer as well as the pretimeout timer. Also, if the hardware watchdog was already running, watchdog_open() expects the device and module references to have been acquired prior to opening. If cdev_device_add() then fails, the error path drops the device reference but fails to stop the watchdog, cancel the timers, and stop the worker, leaving the watchdog active and timers armed that can later fire and dereference freed memory. Furthermore, if a concurrent watchdog_open() saw hw_running == true before cdev_device_add() was called, it skipped taking its own device reference, allowing put_device() on the error path to free wd_data while the file descriptor is still open. Similarly, when unregistering a running watchdog that is not currently open, the extra hw_running module and device references were never released. Fix the problem by initializing wd_data and taking the running-watchdog references before exposing the device via misc_register(), stopping the watchdog and canceling both the heartbeat and pretimeout timers and stopping the worker on registration failure, and releasing unclaimed running-watchdog references on registration failure and unregistration. Fixes: ee142889e32f ("watchdog: Introduce WDOG_HW_RUNNING flag") Reported-by: Reported-by: Sashiko <sashiko@sashiko.dev> Link: https://sashiko.dev/#/bug/linux-50fc8217-05c7-468f-a867-6ba925b50226 Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Link: https://patch.msgid.link/20261027160353.2519323-1-linux@roeck-us.net Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'rust/kernel/alloc/allocator')
0 files changed, 0 insertions, 0 deletions