diff options
| author | YuanZhe Liu <25031212351@stu.xidian.edu.cn> | 2026-11-02 16:57:24 +0800 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2026-11-19 17:57:10 +0100 |
| commit | e8645fe7419828fd95a90171149c565c1bb72911 (patch) | |
| tree | fad87e78a67b17d8e65b688c315478c5653701ae /rust/kernel/alloc | |
| parent | ed52e47133f72195f246a9f70c98e47431bb566d (diff) | |
fbdev: smscufx: keep the usb_device alive while ufx_data is in use
ufx_usb_probe() stores the usb_device pointer in dev->udev without
taking a reference, and ufx_usb_disconnect() does not wait for in-flight
control transfers. A mode set or blank request that runs while the
device is being unplugged - through ufx_ops_set_par() or ufx_ops_blank()
on an open /dev/fbN file - keeps issuing synchronous control messages for
the whole ufx_set_vid_mode() sequence, including two msleep(1) delays in
ufx_config_pix_clk(). Once the disconnect callback returns, the USB core
may release the usb_device, and the next ufx_reg_write()/ufx_reg_read()
dereferences dev->udev through __create_pipe():
general protection fault, probably for non-canonical address
0xdffffc0000000006: 0000 [#1] SMP
KASAN: null-ptr-deref in range [0x0000000000000030-0x0000000000000037]
RIP: __create_pipe include/linux/usb.h:2031
Call Trace:
ufx_set_vid_mode
ufx_ops_set_par
fb_set_var
fb_set_var_from_user
store_rotate
Take a reference to the usb_device in ufx_usb_probe() and drop it in
ufx_free(), so dev->udev and dev->gdev stay valid until the last
ufx_data user is gone. The control transfers then fail with -ENODEV
instead of dereferencing freed memory.
Also return early from ufx_set_vid_mode() while the device is inactive,
matching the other transmit paths. That check alone is not enough,
because it is not serialized against ufx_usb_disconnect() and the
transfer sequence continues after it; it only avoids a long series of
failing transfers.
Fixes: 3c8a63e22a08 ("Add support for SMSC UFX6000/7000 USB display adapters")
Signed-off-by: YuanZhe Liu <25031212351@stu.xidian.edu.cn>
Cc: stable@vger.kernel.org
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'rust/kernel/alloc')
0 files changed, 0 insertions, 0 deletions
