diff options
| author | Chris Mason <mason@kernel.org> | 2026-11-12 16:46:14 -0500 |
|---|---|---|
| committer | Carlos Maiolino <cem@kernel.org> | 2026-11-16 11:45:49 +0100 |
| commit | f01f70e00770c6d21b468f80b488e6407a6947dc (patch) | |
| tree | bf24b1b06714781da9b3ec0f606015058768d275 /rust/kernel/alloc | |
| parent | bdc3ee45df55d8aa478d8a5d6a7e9b1186f511ba (diff) | |
xfs: refuse fallocate racing with realtime flag changes
On a zoned XFS, fallocate() can dereference a NULL pointer if the
realtime flag of the file is set during the call.
xfs_file_fallocate() reserves zoned space only for a zoned inode, and
tests for that before it takes the iolock. FS_IOC_FSSETXATTR can change
the realtime flag of a file with no blocks in that gap.
xfs_falloc_force_zero() then sees a zoned inode and reads the
reservation, which is NULL:
fallocate(FALLOC_FL_ZERO_RANGE) FS_IOC_FSSETXATTR
=============================== =================
takes the iolock
sees that the inode is not zoned
waits for the iolock
sets the realtime flag
drops the iolock
xfs_falloc_force_zero()
sees that the inode is zoned
/* ac is NULL */
The fix used here is to test again under the iolock, and to fail the
call with -EINVAL if the answer has changed, as the write path does.
Fixes: 058dd70c65ab ("xfs: implement buffered writes to zoned RT devices")
Signed-off-by: Chris Mason <mason@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
Diffstat (limited to 'rust/kernel/alloc')
0 files changed, 0 insertions, 0 deletions
