diff options
| author | ozgun kultekin <ozgunkultekin@gmail.com> | 2026-11-17 16:21:59 -0800 |
|---|---|---|
| committer | Paulo Alcantara <pc@manguebit.org> | 2026-11-19 10:41:04 -0300 |
| commit | f834c81f108f8bdb0e3aa8375a536fb6dda56c70 (patch) | |
| tree | 96a93594937381e649bded386f5bdee94bc6bc9d /rust/kernel/alloc | |
| parent | 340ca61e9d31c31403013dc9190550d615844828 (diff) | |
smb: client: do not let the server grow a write subrequest
smb2_writev_callback() takes the byte count from the SMB2 WRITE
response, masks it with 0xFFFF if it is larger than the request (for
old OS/2 servers), and then copies it into wdata->subreq.len. A server
can return a count that is still larger than the request after the
mask, for example 0x8002 for a 5-byte write or 0xFFFF for a 4 KiB
write, and the subrequest then covers data that was never sent.
netfs uses the subrequest length to decide how far the write collector
may advance. With a grown subrequest the collector moves collected_to
past the data that was issued: netfs_writeback_unlock_folios() walks
folio_queue slots that were never filled, and
rolling_buffer_delete_spent() frees folio_queue segments that later
in-flight subrequests still use. This is a use-after-free that a
malicious or broken server triggers from an ordinary write:
BUG: KASAN: slab-use-after-free in netfs_limit_iter+0xed4/0x1040
Read of size 1 at addr ff11000010561511 by task kworker/u8:4/63
Workqueue: events_unbound netfs_write_collection_worker
netfs_limit_iter+0xed4/0x1040
netfs_retry_writes+0x1410/0x1e90
netfs_write_collection+0x2647/0x3880
netfs_write_collection_worker+0x1cd/0x3e0
Allocated by task 141:
netfs_folioq_alloc+0x39a/0x470
rolling_buffer_init+0x29/0xc0
netfs_create_write_req+0x12f/0x840
Freed by task 42:
rolling_buffer_delete_spent+0xb1/0x220
netfs_write_collection+0x1f62/0x3880
Never change the subrequest length from the response. If the count is
still larger than the request after the mask, fail the write with -EIO
and record it with a new write_overlarge trace point, like the read
path does with read_overlarge. A short count still returns -ENOSPC as
before.
The folio_queue form of the use-after-free exists since
commit cd0277ed0c18 ("netfs: Use new folio_queue data type and
iterator instead of xarray iter").
Fixes: 3ee1a1fc3981 ("cifs: Cut over to using netfslib")
Cc: stable@vger.kernel.org
Signed-off-by: ozgun kultekin <ozgunkultekin@gmail.com>
Reviewed-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Paulo Alcantara <pc@manguebit.org>
Diffstat (limited to 'rust/kernel/alloc')
0 files changed, 0 insertions, 0 deletions
