diff options
| author | Luiz Georg <luizgngeorg@gmail.com> | 2026-07-10 17:20:31 +0100 |
|---|---|---|
| committer | Gary Guo <gary@garyguo.net> | 2026-07-13 12:08:46 +0100 |
| commit | f26f2f22c6d16d6019fbd1248681e57a1a533bd3 (patch) | |
| tree | b591903dc0cecddf722bf53835a16a00591b1f57 /rust/pin-init | |
| parent | a13c140cc289c0b7b3770bce5b3ad42ab35074aa (diff) | |
rust: pin-init: internal: error on duplicate `#[pin]` attribute
Duplicated `#[pin]` has no effect, thus error if misused.
Reported-by: Mohamad Alsadhan <mo@sdhn.cc>
Closes: https://github.com/Rust-for-Linux/pin-init/issues/119
Signed-off-by: Luiz Georg <luizgngeorg@gmail.com>
Link: https://patch.msgid.link/20260710-pin-init-sync-v1-1-8fa16cde87ae@garyguo.net
[ Reworded commit message, and change the logic so code generation still
continue after reporting error - Gary ]
Signed-off-by: Gary Guo <gary@garyguo.net>
Diffstat (limited to 'rust/pin-init')
| -rw-r--r-- | rust/pin-init/internal/src/pin_data.rs | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/rust/pin-init/internal/src/pin_data.rs b/rust/pin-init/internal/src/pin_data.rs index 9fbbd25bcaac..263f67300727 100644 --- a/rust/pin-init/internal/src/pin_data.rs +++ b/rust/pin-init/internal/src/pin_data.rs @@ -85,7 +85,10 @@ pub(crate) fn pin_data( .map(|field| { let len = field.attrs.len(); field.attrs.retain(|a| !a.path().is_ident("pin")); - let pinned = len != field.attrs.len(); + let pinned_count = len - field.attrs.len(); + if pinned_count > 1 { + dcx.error(&field, "#[pin] attribute specified more than once"); + } let cfg_attrs = field .attrs @@ -95,7 +98,7 @@ pub(crate) fn pin_data( FieldInfo { field: &*field, - pinned, + pinned: pinned_count != 0, cfg_attrs, } }) |