diff options
| author | Kyle Zeng <kylebot@openai.com> | 2026-10-29 14:09:57 -0400 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2026-11-03 11:04:43 +0100 |
| commit | 2e54b3e187300893688c2c7517894f5d96732e05 (patch) | |
| tree | 291a0016450491c30aa5d0ba9a064cd89982942a /scripts/const_structs.checkpatch | |
| parent | 213d491308b99d026514c93980cf8dd572226b1b (diff) | |
net/sched: sch_qfq: prevent aggregate self-replacement
qfq_change_class() snapshots the current aggregate settings while
holding the qdisc tree lock, but drops the lock before selecting the
destination aggregate. During that gap, qfq_enqueue() can move the
class to an aggregate matching the requested settings.
When qfq_change_class() resumes, qfq_find_agg() then returns cl->agg.
If it is a singleton, qfq_deact_rm_from_agg() frees the aggregate
before qfq_add_to_agg() immediately accesses the same pointer, causing
a use-after-free.
While holding the tree lock, skip the replacement when the destination
is already the current aggregate. Any estimator replacement has already
completed, so the class change can finish normally.
Fixes: 462dbc9101ac ("pkt_sched: QFQ Plus: fair-queueing service at DRR cost")
Link: https://lore.kernel.org/netdev/20260731140533.566493-1-david.lee@trailofbits.com/
Cc: stable@vger.kernel.org
Signed-off-by: Kyle Zeng <kylebot@openai.com>
Co-developed-by: David Lee <david.lee@trailofbits.com>
Signed-off-by: David Lee <david.lee@trailofbits.com>
Link: https://patch.msgid.link/20261029180957.43015-1-david.lee@trailofbits.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'scripts/const_structs.checkpatch')
0 files changed, 0 insertions, 0 deletions
