summaryrefslogtreecommitdiff
path: root/scripts/diffconfig
diff options
context:
space:
mode:
authorRidong Chen <chenridong@xiaomi.com>2026-11-12 11:19:31 +0800
committerTejun Heo <tj@kernel.org>2026-11-13 09:23:33 -1000
commite234ed1bb82c96a5643fd70784f16cf3d72eeed3 (patch)
tree4bda09c25f9793ba5537bc9b61f71b8a8826db77 /scripts/diffconfig
parentc1ad01173511e8aec378af9f5285f98b767b1381 (diff)
cpuset: generalize the validate_partition() interface
Refactor validate_partition() to take the parent partition, the new partition root state, the new effective exclusive CPUs and the CPUs to be deleted, instead of a trial cpuset. A NULL parent stands for a remote partition, whose CPUs come from top_cpuset. This makes the interface flexible enough to handle both local and remote partition validation. This also fixes a false PERR_NOCPUS error when expanding a remote partition. The no CPU left for tasks check in partition_cpus_change() is done against the cgroup parent, but the CPUs of a remote partition come from top_cpuset, not from its parent. For example, on a 4-CPU system: echo 2-3 > P/cpuset.cpus echo 2-3 > P/cpuset.cpus.exclusive echo 2-3 > P/C/cpuset.cpus echo 2 > P/C/cpuset.cpus.exclusive echo root > P/C/cpuset.cpus.partition (a task in P) echo 2-3 > P/C/cpuset.cpus.exclusive cat P/C/cpuset.cpus.partition root invalid (Parent is not a partition root) The effective_cpus of P is 3, a subset of the new exclusive CPUs 2-3 of C, and P has a task, so the expansion is rejected. However, P is not a partition root and does not give any CPU to C, and top_cpuset still has CPUs 0-1 for the task. Enabling C directly with exclusive CPUs 2-3 succeeds, as remote_partition_enable() checks top_cpuset instead. The no CPU left for tasks check now uses the given parent instead of parent_cs(cs), and top_cpuset for a remote partition, as that is where its CPUs are taken from. The housekeeping conflict check is folded into validate_partition(). It is skipped when the parent is not a valid partition root, as @cs can't be a valid local partition in that case. Use the new interface for local partition enablement in update_parent_effective_cpumask() and in partition_cpus_change(), replacing the open-coded checks there. The order of the checks is now the same for both paths: empty CPUs, housekeeping conflict, then no CPU left for tasks. Add a test case to test_cpuset_prs.sh for the remote partition expansion above. Fixes: 181c8e091aae ("cgroup/cpuset: Introduce remote partition") Signed-off-by: Ridong Chen <chenridong@xiaomi.com> Reviewed-by: Guopeng Zhang <zhangguopeng@kylinos.cn> Reviewed-by: Waiman Long <longman@redhat.com> Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'scripts/diffconfig')
0 files changed, 0 insertions, 0 deletions