diff options
| author | Sasha Levin <sashal@kernel.org> | 2026-10-28 10:44:43 -0400 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2026-10-31 16:37:46 +0100 |
| commit | 1886b8132cd37edbc28b55f30a885011aa0bbe8a (patch) | |
| tree | 61fe31d316c0a2ced84d54a229dc62941989e4f2 /scripts | |
| parent | 016fe9695e6dc1322ddfe8c7dbc7b973483b4a24 (diff) | |
ALSA: hda/core: Fix double free on stream page allocation failure
Since commit f16eaa38ea64 ("ALSA: hda/core: add cleanup in
snd_hdac_bus_alloc_stream_pages()"), snd_hdac_bus_alloc_stream_pages()
frees the BDL and position buffers it has already allocated when a
later allocation fails. snd_dma_free_pages() doesn't clear dmab->area,
so the freed buffers still look allocated to
snd_hdac_bus_free_stream_pages(), which the HDA controller drivers call
from their destructors, and they are freed a second time when the
device is removed.
With fault injection failing the CORB/RIRB buffer allocation of
snd-hda-intel on a QEMU ich9-intel-hda, unbinding the device then
crashes:
page dumped because: VM_BUG_ON_PAGE(page_ref_count(page) == 0)
kernel BUG at include/linux/mm.h:1986!
Call Trace:
___free_pages+0x9b/0xa0
free_pages_exact+0xa5/0xd0
snd_hdac_bus_free_stream_pages+0x43/0xb0 [snd_hda_core]
azx_free+0xb3/0x1b0 [snd_hda_intel]
azx_dev_free+0xd/0x20 [snd_hda_intel]
Clear the buffer pointers after freeing them in the error path.
Fixes: f16eaa38ea64 ("ALSA: hda/core: add cleanup in snd_hdac_bus_alloc_stream_pages()")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Link: https://patch.msgid.link/20261028144443.992569-1-sashal@kernel.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions
