diff options
| author | Tejun Heo <tj@kernel.org> | 2026-05-17 07:43:16 -1000 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2026-05-17 09:06:38 -1000 |
| commit | 515e3996a4c26e7f955c13b3b19522a2c8642af9 (patch) | |
| tree | af3c700274c1d52690c1a63ca37a3120b61a6ac5 /scripts | |
| parent | 6ae315d37924435516d697ea7dde0b799a5928e0 (diff) | |
sched_ext: Fix deadlock between scx_root_disable() and concurrent forks
scx_root_disable() enters SCX_DISABLING before it grabs scx_enable_mutex to
clear __scx_switched_all and scx_switching_all. task_should_scx() short-circuits on DISABLING,
so forks in that window land on fair while next_active_class() still skips
fair - the new tasks stall.
This can deadlock the disable path itself: scx_alloc_and_add_sched() runs
under scx_enable_mutex and creates a helper kthread; if that new kthread is
one of the stalled fair tasks, the mutex holder waits forever and
scx_root_disable() can never make progress. Only sub-sched support exposes
this, since sub-sched enables are the only path where
scx_alloc_and_add_sched() can race the root's disable.
Move the DISABLING check after @scx_switching_all. @scx_switching_all
serves as a proxy for __scx_switched_all, so while it's set, forks keep
going to scx. Once cleared, DISABLING applies normally.
v2: Reword in-source comment and description. (Andrea)
Fixes: 337ec00b1d9c ("sched_ext: Implement cgroup sub-sched enabling and disabling")
Signed-off-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Andrea Righi <arighi@nvidia.com>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions
