summaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorAntheas Kapenekakis <lkml@antheas.dev>2026-11-02 18:40:52 +0100
committerTakashi Iwai <tiwai@suse.de>2026-11-05 08:54:45 +0100
commitba39a31448857da3b848174c9130b466b3ccddba (patch)
tree025b84cf41c2140431caa80b42415fd071c0d173 /scripts
parenta3cf5ebab5f1db9e6f751e2a08df05a84f37ea57 (diff)
ALSA: hda/tas2781: Prevent throwing away custom calibration addresses
The V2 UEFI spec for per-device calibration data in TAS allows for manufacturers to specify up to five custom calibration register addresses and values to optimize per-device in factory. A basic description of the spec is found in a comment in function tas2781_apply_calib(). However, currently, for the condition of p->dspbin_typ != TASDEV_BASIC, if custom calibration addresses have been provided by the manufacturer, they are ignored and the ones listed in firmware are used. In case the manufacturer chose to change different registers other than the default ones (r0, invr0, r0_low, pow, tlimit), this causes the UEFI calibration data to scratch different registers and cause the firmware to misbehave. This is true in the Xbox ROG Ally X, for one of the firmwares, where it pops and has audio dropouts after the calibration data is applied. Therefore, add a new bool to indicate that UEFI supplied custom calibration addresses, and if so, use them regardless of dspbin_typ. Closes: https://lore.kernel.org/all/179122346529.6.9250312386131579603.1671009695@8alias.com/ Co-developed-by: Matthew Schwartz <matthew.schwartz@linux.dev> Signed-off-by: Matthew Schwartz <matthew.schwartz@linux.dev> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> Link: https://patch.msgid.link/20261102174052.1216670-1-lkml@antheas.dev Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions