summaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorStefano Munari <stefanomunari.sm@gmail.com>2026-11-03 00:51:33 +0100
committerJakub Kicinski <kuba@kernel.org>2026-11-09 16:15:03 -0800
commitbe9587c47db16faaca5415f533637755c65a4eb0 (patch)
tree784fabaac788232abba44a174d15f1f8581c0b65 /scripts
parentd694decf12ca0b55f9e11eacbc00077c99c5a65d (diff)
net: usb: lan78xx: resume phylink on non-reset USB resume
lan78xx_suspend() calls phylink_suspend(dev->phylink, false) on an open interface, which always stops phylink and halts the PHY. The matching phylink_resume() is only called from lan78xx_reset_resume(). When the USB device stays powered across system sleep (e.g. s2idle) and the USB core calls .resume instead, the link stays down until the interface is brought down and up by hand. The ifdown triggers: WARNING: drivers/net/phy/phy.c:1670 at phy_stop+0x44/0xc8 called from state HALTED Move phylink_resume() to the end of lan78xx_resume(), which both resume paths go through, and call it only if the resume succeeded and the interface was open, mirroring lan78xx_suspend(). As a side effect, lan78xx_reset_resume() no longer starts phylink on a closed interface. Tested on a Raspberry Pi 3B+ (LAN7515) with s2idle: the link now comes back up on its own after resume and ifdown no longer warns. Fixes: e110bc825897 ("net: usb: lan78xx: Convert to PHYLINK for improved PHY and MAC management") Signed-off-by: Stefano Munari <stefanomunari.sm@gmail.com> Tested-by: Oleksij Rempel <o.rempel@pengutronix.de> Link: https://patch.msgid.link/20261102235133.23011-1-stefanomunari.sm@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions