diff options
| author | Dan Carpenter <error27@gmail.com> | 2026-10-01 09:51:39 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-10-02 12:26:39 +0100 |
| commit | 015f14e42b223c03e54c12be78247a3735081c21 (patch) | |
| tree | e8e8cd7702ae902a49d02d8f70bcdd572418cb81 /tools/lib/python/kdoc/python_version.py | |
| parent | d532e2f5c288556075dc429941861391118787a0 (diff) | |
ASoC: codecs: aw88261: small cleanup in aw88261_set_tdm_slot()
This code triggers a Smatch false positive:
sound/soc/codecs/aw88261.c:858 aw88261_set_tdm_slot()
error: uninitialized symbol 'chan'.
This would only happen if both the tx and rx masks were zero which is
a nonsense scenario and reviewing the callers shows that it never
happens.
However, if the rx_mask is zero then we're comparing the mask from RX
against the chan from TX which is confusing:
if ((rx_mask & ~BIT(chan)) != 0) {
^^ rx ^^^^ tx chan
Of course, in that case the condition is going to be false because
the rx_mask is zero. So it's fine. But it would be more clear to move
the condition inside the if statement and it silences the static checker
warning as well.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Link: https://patch.msgid.link/ar4C-0NIYXiAvxvv@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'tools/lib/python/kdoc/python_version.py')
0 files changed, 0 insertions, 0 deletions
