diff options
| author | Tarun Khandelwal <tarun@supabase.io> | 2026-09-29 15:18:12 +0530 |
|---|---|---|
| committer | Miklos Szeredi <mszeredi@redhat.com> | 2026-10-15 13:51:59 +0200 |
| commit | ee8f6dfccba121900a00122e7c314352db4bcbb3 (patch) | |
| tree | 7fc3112ab04a0e69569abba8d582c5311a85b64b /tools/lib/python/kdoc/python_version.py | |
| parent | b776cbe24cc1b79c7f5101762b0069b3f48b6a4b (diff) | |
fuse: propagate SB_POSIXACL to submounts
fuse_fill_super_common() always sets SB_POSIXACL on the superblock, but
fuse_fill_super_submount() never does. Submount superblocks are created
from an fs_context with no sb_flags, so the superblock of an automounted
FUSE_ATTR_SUBMOUNT directory (e.g. a virtiofs export containing another
host mount) lacks SB_POSIXACL, even though it shares the fuse_conn, and
thus fc->posix_acl, with its parent.
Since IS_POSIXACL() is false on such a submount, the VFS:
- fails setting POSIX ACLs with -EOPNOTSUPP and hides existing ACLs,
without sending any request to the server;
- applies the umask itself on create, so default ACLs on the server are
not honoured for new files;
- skips ACL checks in acl_permission_check(), so with
default_permissions (implied by FUSE_POSIX_ACL) access is decided by
the mode bits alone and restrictive ACL entries are not enforced.
Copy SB_POSIXACL from the parent superblock, as is already done for the
other superblock fields inherited from it. It cannot be set in
fuse_sb_defaults(), because fuse_fill_super_common() checks whether the
flag was passed at mount time to decide fc->dont_mask before setting it.
Reproducer, with virtiofsd 1.10.0 started with --posix-acl and an export
containing a nested mount:
host# mount -t tmpfs none /srv/share
host# mkdir /srv/share/child
host# mount -t tmpfs none /srv/share/child
host# touch /srv/share/rootfile /srv/share/child/childfile
guest# mount -t virtiofs <tag> /mnt
guest# setfacl -m u:12345:rw /mnt/rootfile # works
guest# setfacl -m u:12345:rw /mnt/child/childfile
setfacl: /mnt/child/childfile: Operation not supported
With this patch the second setfacl succeeds, ACLs set on the host are
reported by getfacl on the submount, and default ACLs and ACL-based
access checks behave the same as on the root mount. Tested on v7.3-rc5
in a QEMU guest.
Signed-off-by: Tarun Khandelwal <tarun@supabase.io>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'tools/lib/python/kdoc/python_version.py')
0 files changed, 0 insertions, 0 deletions
