diff options
| author | David Heidelberg <david@ixit.cz> | 2026-09-21 12:46:23 +0200 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2026-10-14 13:29:55 +0100 |
| commit | e60dc9c05e0f415ef8bc63b3179abdd49830a619 (patch) | |
| tree | 7e45c800b26fdeb7ed0ac730e34d996391b30572 /tools/lib/python | |
| parent | 186fc521f211a207c323b753659f28d3dda7bc45 (diff) | |
backlight: qcom-wled: Fix WLED3 brightness register stride
WLED3 has a 16-bit brightness register pair per string, at 0x40 + 2*n,
which is what the pm8941-wled driver wrote to:
rc = regmap_bulk_write(wled->regmap,
wled->addr + WLED3_CTRL_REG_VAL_BASE + 2 * i,
v, 2);
The restructuring for WLED3 turned that into WLED3_SINK_REG_BRIGHT(n),
defined as 0x40 + n, so the two byte writes for consecutive strings
overlap: string 1 overwrites the MSB of string 0 with its own LSB, and
with the default three strings only string 1 ends up with the requested
value.
Use the 2 byte stride.
Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3")
Cc: stable@vger.kernel.org
Assisted-by: LLM
Signed-off-by: David Heidelberg <david@ixit.cz>
Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://patch.msgid.link/20260921-qcom-wled-backlight-v4-2-bab8c7ef73cb@ixit.cz
Signed-off-by: Lee Jones <lee@kernel.org>
Diffstat (limited to 'tools/lib/python')
0 files changed, 0 insertions, 0 deletions