summaryrefslogtreecommitdiff
path: root/tools/perf/python
diff options
context:
space:
mode:
authorJames Clark <james.clark@linaro.org>2026-10-06 14:03:31 +0100
committerArnaldo Carvalho de Melo <acme@redhat.com>2026-10-19 09:24:59 -0300
commit5927da00783dc8e5a20e059ba2762cdcff1fd3b6 (patch)
treee9530b9cb1c71be6fc167ce1f2f0eec88932fd9c /tools/perf/python
parent1c90f0a3c8a1c4e38f9edd97af9e20848805a7fb (diff)
perf timechart: Fix task row type narrowing in goto_task()
Mypy cannot narrow Row to TaskRow or IoRow when the class passed to isinstance() comes from a loop variable, causing the perf build to fail with: python/ttimechart.py:1686: error: "Row" has no attribute "task" [attr-defined] Check against TaskRow and IoRow explicitly so mypy can verify access to the task attribute. The tasks and I/O views contain TaskRow and IoRow instances respectively, so task navigation behaves as before. Fixes: e7a72d6919804e5e ("perf timechart: Add an interactive --tui mode") Reviewed-by: Ian Rogers <irogers@google.com> Assisted-by: Codex:GPT-6.1-Sol Signed-off-by: James Clark <james.clark@linaro.org> Cc: Alice Rogers <alice.mei.rogers@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/python')
-rwxr-xr-xtools/perf/python/ttimechart.py5
1 files changed, 2 insertions, 3 deletions
diff --git a/tools/perf/python/ttimechart.py b/tools/perf/python/ttimechart.py
index 34ecf84e68c1..d7ba0276a9fb 100755
--- a/tools/perf/python/ttimechart.py
+++ b/tools/perf/python/ttimechart.py
@@ -1676,14 +1676,13 @@ class TimechartApp(App):
def goto_task(self, tid: int, time: Optional[float]) -> None:
"""Select the task in the tasks or I/O view, optionally moving the cursor."""
- for tab_id, view_id, row_type in (("tasks", "#tasks_view", TaskRow),
- ("io", "#io_view", IoRow)):
+ for tab_id, view_id in (("tasks", "#tasks_view"), ("io", "#io_view")):
views = self.query(view_id)
if not views:
continue
view = views.first(TimelineView)
for idx, row in enumerate(view.rows):
- if isinstance(row, row_type) and row.task.tid == tid:
+ if isinstance(row, (TaskRow, IoRow)) and row.task.tid == tid:
self.query_one(TabbedContent).active = tab_id
if time is not None:
self.window = self.window.with_cursor(time)