diff options
| author | Syed Saba Kareem <Syed.SabaKareem@amd.com> | 2026-09-24 18:11:52 +0530 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-09-24 19:55:00 +0100 |
| commit | d06607bafb36abc14ed34c8adfb1239bebcd83d1 (patch) | |
| tree | 42ec3776c343c36366062cb6cc04134a8f768502 /tools/perf/scripts/python/bin/stackcollapse-report | |
| parent | be190d999369fad147e94124cbab0b28583496e7 (diff) | |
ASoC: amd: acp: fix TAS2783 SoundWire codec unmet dependencies
SND_SOC_AMD_LEGACY_SDW_MACH unconditionally selects SND_SOC_TAS2783_SDW,
but that codec depends on SND_SOC_SDCA and EFI in addition to SOUNDWIRE.
An unconditional select force-enables the codec even when those
dependencies are not met, which the kernel test robot reported as unmet
direct dependencies when EFI=n:
WARNING: unmet direct dependencies detected for SND_SOC_TAS2783_SDW
Depends on [n]: SOUND [=y] && SND [=y] && SND_SOC [=y] &&
SOUNDWIRE [=y] && SND_SOC_SDCA [=y] && EFI [=n]
Selected by [y]:
- SND_SOC_AMD_LEGACY_SDW_MACH [=y] && ...
The other SoundWire codecs selected by this machine driver only depend
on SOUNDWIRE, which the driver already depends on, so they select
cleanly. SND_SOC_TAS2783_SDW is the only one that additionally needs
the SDCA core and EFI (it reads speaker calibration data from EFI
variables).
SND_SOC_SDCA cannot simply be selected here, as that introduces a
recursive Kconfig dependency (SOUNDWIRE depends on SND_SOC_SDCA_OPTIONAL,
whose default pulls in SND_SOC_SDCA), and EFI is a platform feature that
must not be selected by a driver. Instead, guard the select with the
missing dependencies so the codec is only (and always) built when they
are satisfied:
select SND_SOC_TAS2783_SDW if SND_SOC_SDCA && EFI
This keeps the TAS2783 SoundWire codec built together with the machine
driver on platforms that can use it, while avoiding the unmet dependency
when SND_SOC_SDCA or EFI is disabled.
Fixes: 28114992dd2f ("ASoC: amd: acp: enable TAS2783 and add RT712-VB SoundWire machine")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202609182147.gfofWIXW-lkp@intel.com/
Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
Link: https://patch.msgid.link/20260924124205.3376083-1-syed.sabakareem@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/bin/stackcollapse-report')
0 files changed, 0 insertions, 0 deletions
