diff options
| author | Chao Shi <coshi036@gmail.com> | 2026-08-06 12:58:30 -0400 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2026-09-10 09:27:24 +0200 |
| commit | bc411b171a89abc9b3a267599919a4dbc826e626 (patch) | |
| tree | 7349589a13df388b74f65c7c19103dd8cfffc349 /tools/perf/scripts/python/stackcollapse.py | |
| parent | 7d439c46c9230b9ef9da8d164dcd8795b528e631 (diff) | |
buffer: detect metadata write errors with buffer_write_io_error()
Both places in this file that report a metadata write error to a caller do
it by testing !buffer_uptodate() after waiting for the write. That works
only because the write completion handlers clear BH_Uptodate when the write
fails, which is what this series is removing: a buffer whose write failed
still holds the correct data, and saying otherwise makes callers rewrite,
re-read or WARN over a buffer that was never wrong.
BH_Write_EIO is the flag that actually means "the last write of this buffer
failed", and both handlers already set it via mark_buffer_write_io_error().
Test that instead.
No behaviour change: today a failed write through bh_end_write() or
bh_end_async_write() sets BH_Write_EIO and clears BH_Uptodate together, so
the two tests agree. They stop agreeing at the end of the series, and this
one stays right.
Acked-by: Weidong Zhu <weizhu@fiu.edu>
Signed-off-by: Chao Shi <coshi036@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/2b309196b883cc8979800911a47668e225401b2c.1785951556.git.coshi036@gmail.com
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/stackcollapse.py')
0 files changed, 0 insertions, 0 deletions
