diff options
| author | Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> | 2026-08-21 12:06:20 +0530 |
|---|---|---|
| committer | Bjorn Andersson <andersson@kernel.org> | 2026-10-05 09:10:42 +0200 |
| commit | f38399670d0701ede4f8da397807aa64d7dc98be (patch) | |
| tree | 6a62c19b128c7261a7b1ab5b58e99d4f426d0d73 /tools/perf/scripts/python/stackcollapse.py | |
| parent | 091269da39eb0a52cca2549e9ba522ab7b841ff2 (diff) | |
soc: qcom: geni-se: Fix write to read-only firmware buffer
geni_find_protocol_fw() casts fw->data to a non-const struct se_fw_hdr
pointer and writes back the rounded-up fw_size value:
sefw->fw_size_in_items = cpu_to_le16(fw_size);
The firmware subsystem maps the firmware blob read-only. Writing through
the cast pointer causes a level-3 permission fault on AArch64 and
crashes the kernel during driver probe.
The write-back is no longer necessary: geni_find_protocol_fw() now
propagates the rounded size to the caller via fw_size_out. Remove the
write-back and make sefw (and the hdr pointer in the caller)
const-correct.
Fixes: d4bf06592ad6 ("soc: qcom: geni-se: Add support to load QUP SE Firmware via Linux subsystem")
Cc: stable@vger.kernel.org
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260821-fix-write-to-read-only-firmware-buffer-v3-4-43e6a3abd651@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/stackcollapse.py')
0 files changed, 0 insertions, 0 deletions
