summaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python
diff options
context:
space:
mode:
authorMark Rutland <mark.rutland@arm.com>2026-09-08 16:17:34 +0100
committerCatalin Marinas <catalin.marinas@arm.com>2026-09-24 14:52:08 +0100
commit95d2c5f6663bb416f9cb94a920d840dadc958215 (patch)
tree400ffd3055b7ff25817e608ed8f76a61b3a7da5c /tools/perf/scripts/python
parentfb532fdb443055dce5c31e999e064711179151fb (diff)
arm64: percpu: Add infrastructure for preemptible this_cpu_*() ops
Currently arm64's this_cpu_*() ops transiently disable preemption in order to guarantee that the address generation and memory access(es) occur on the same CPU. Transiently disabling preemption can be expensive. When re-enabling preemption it is necessary to make a conditional function call to preempt_schedule[_notrace]() in order to handle the rare case that the task needs to be rescheduled. The potential function call has a number of negative effects on code generation (e.g. due to the need to create a stack frame and spill registers), and the conditionality can result in poor code generation and/or poor branch prediction. This patch adds infrastructure for a scheme where this_cpu_*() ops do not need to transiently disable preemption, avoiding the negative impacts described above. Individual operations will be converted in subsequent patches. Each operation registers a critical section during which the exception return code will adjust the offset and addresses if preemption occurs mid-sequence. The critical section is registered/unregistered with a small prologue and epilogue which encodes three distinct GPRs (<pcp>, <off>, <addr>) into a new thread_info::pcpu_gprs field: // Prologue. Enable fixups for <off> and <addr>. mrs <tsk>, sp_el0 mov <tmp>, #__VAL_PCPU_GPRS(<pcp>, <off>, <addr>) strh <tmp>, [<tsk>, #TSK_TI_PCPU_GPRS] // Generate cpu-specific address mrs <off>, TPIDR_ELx add <addr>, <pcp>, <off> // Perform access sequence ldr <val>, [<addr>] // Epilogue. Disable fixups strh wzr, [<tsk>, #TSK_TI_PCPU_GPRS] If an exception is taken from within the critical section, the exception return code will adjust <off> to be the current CPU's offset, and will adjust <addr> to be (<pcp> + <off>). Distinct registers are used for <pcp>, <off>, and <addr>, so that the fixup can be applied safely at any point during the critical section. To ensure that this_cpu_*() operations within exception handlers work correctly and do not corrupt state, thread_info::pcpu_gprs is saved into a new pt_regs::pcpu_gprs field upon exception entry, and restored upon exception return. Looking at a simple this_cpu_operation: | void outline_this_cpu_add_u64(u64 __percpu *p, u64 v) | { | this_cpu_add(*p, v); | } Atop v7.2-rc4, with GCC 15.2.0 and defconfig, this is compiled as: | <outline_this_cpu_add_u64>: | paciasp | stp x29, x30, [sp, #-16]! | mrs x2, sp_el0 | mov x29, sp | ldr w3, [x2, #8] | add w3, w3, #0x1 | str w3, [x2, #8] | mrs x3, tpidr_el1 | add x0, x0, x3 | 1: ldxr x5, [x0] | add x5, x5, x1 | stxr w4, x5, [x0] | cbnz w4, 1b | ldr x0, [x2, #8] | sub x0, x0, #0x1 | str w0, [x2, #8] | cbz x0, 2f | ldr x0, [x2, #8] | cbnz x0, 3f | 2: bl preempt_schedule_notrace | 3: ldp x29, x30, [sp], #16 | autiasp | ret With the scheme added in this patch, this can be compiled as: | <outline_this_cpu_add_u64>: | mrs x2, sp_el0 | mov x4, #0xc80 // __VAL_PCPU_GPRS(x0, x4, x3) | strh w4, [x2, #20] | mrs x4, tpidr_el1 | add x3, x0, x4 | 1: ldxr x6, [x3] | add x6, x6, x1 | stxr w5, x6, [x3] | cbnz w5, 1b | strh wzr, [x2, #20] | ret Signed-off-by: Mark Rutland <mark.rutland@arm.com> Tested-by: Muhammad Usama Anjum <usama.anjum@arm.com> Cc: Ada Couprie Diaz <ada.coupriediaz@arm.com> Cc: Ard Biesheuvel <ardb@kernel.org> Cc: James Morse <james.morse@arm.com> Cc: Jinjie Ruan <ruanjinjie@huawei.com> Cc: Marc Zyngier <maz@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Vladimir Murzin <vladimir.murzin@arm.com> Cc: Will Deacon <will@kernel.org> Cc: Yang Shi <yang@os.amperecomputing.com> Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com> [catalin.marinas@arm.com: fixed typos in commit log and code comments] Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions