diff options
| author | Cheng-Yang Chou <yphbchou0911@gmail.com> | 2026-04-20 00:36:13 +0800 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2026-04-20 06:54:44 -1000 |
| commit | ce0fb14ea592eb84d6a01b948f2684ddfaac5832 (patch) | |
| tree | 6ba3e111b8f88f2adad3f0ab9f87c3617e986bbf /tools/sched_ext | |
| parent | e613cc236188bafdc6dd30fd6d26f97b1661c512 (diff) | |
tools/sched_ext: Remove dead -d option in scx_flatcg
The -d option was non-functional, only toggling a variable that was
echoed in the status line but never used to dump the cgroup hierarchy.
Remove the option to avoid documenting dead code as a feature.
Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'tools/sched_ext')
| -rw-r--r-- | tools/sched_ext/scx_flatcg.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/tools/sched_ext/scx_flatcg.c b/tools/sched_ext/scx_flatcg.c index d865c381589b..de2bef86d64d 100644 --- a/tools/sched_ext/scx_flatcg.c +++ b/tools/sched_ext/scx_flatcg.c @@ -130,7 +130,6 @@ int main(int argc, char **argv) struct scx_flatcg *skel; struct bpf_link *link; struct timespec intv_ts = { .tv_sec = 2, .tv_nsec = 0 }; - bool dump_cgrps = false; __u64 last_cpu_sum = 0, last_cpu_idle = 0; __u64 last_stats[FCG_NR_STATS] = {}; unsigned long seq = 0; @@ -148,7 +147,7 @@ restart: assert(skel->rodata->nr_cpus > 0); skel->rodata->cgrp_slice_ns = __COMPAT_ENUM_OR_ZERO("scx_public_consts", "SCX_SLICE_DFL"); - while ((opt = getopt(argc, argv, "s:i:dfvh")) != -1) { + while ((opt = getopt(argc, argv, "s:i:fvh")) != -1) { double v; switch (opt) { @@ -161,9 +160,6 @@ restart: intv_ts.tv_sec = v; intv_ts.tv_nsec = (v - (float)intv_ts.tv_sec) * 1000000000; break; - case 'd': - dump_cgrps = true; - break; case 'f': skel->rodata->fifo_sched = true; break; @@ -177,10 +173,10 @@ restart: } } - printf("slice=%.1lfms intv=%.1lfs dump_cgrps=%d", + printf("slice=%.1lfms intv=%.1lfs", (double)skel->rodata->cgrp_slice_ns / 1000000.0, - (double)intv_ts.tv_sec + (double)intv_ts.tv_nsec / 1000000000.0, - dump_cgrps); + (double)intv_ts.tv_sec + (double)intv_ts.tv_nsec / 1000000000.0); + SCX_OPS_LOAD(skel, flatcg_ops, scx_flatcg, uei); link = SCX_OPS_ATTACH(skel, flatcg_ops, scx_flatcg); |