summaryrefslogtreecommitdiff
path: root/tools/testing/shared/linux.c
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2026-05-20 15:05:04 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2026-05-20 17:13:20 +0200
commit237557b8a81ab948e8332f7c0058e758f081c0a3 (patch)
treecc92ab6ed6aed47405999e2ee9fe7b28038a7df3 /tools/testing/shared/linux.c
parent50030d63b4d3deda4cbea85bb43cfc1785267621 (diff)
sysfs: don't remove existing directory on update failure
When sysfs_update_group() is called for a named group and create_files() fails (e.g. -ENOMEM), internal_create_group() calls kernfs_remove(kn) on the group directory. In the update path, kn was obtained via kernfs_find_and_get() and refers to a directory that already existed before this call. Removing it silently destroys a sysfs group that the caller did not create. Only remove the directory if we created it ourselves. On update failure the directory remains as it is left empty by remove_files() inside create_files(), but can be repopulated by a retry. Cc: Rajat Jain <rajatja@google.com> Fixes: c855cf2759d2 ("sysfs: Fix internal_create_group() for named group updates") Cc: stable <stable@kernel.org> Assisted-by: gkh_clanker_t1000 Reviewed-by: Rafael J. Wysocki (Intel) <rafael@kernel.org> Reviewed-by: Danilo Krummrich <dakr@kernel.org> Link: https://patch.msgid.link/2026052003-uniquely-hastily-c093@gregkh Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools/testing/shared/linux.c')
0 files changed, 0 insertions, 0 deletions