diff options
| author | Hrishikesh Suresh <hrishikesh123s@gmail.com> | 2025-11-19 23:16:10 -0500 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2025-11-20 11:13:04 -0800 |
| commit | 9bef5cead63d5d8fad3ba7ebaf26f3f4ee172c82 (patch) | |
| tree | 805117f19ec20f2b786d5d19e30386f47746025b /tools | |
| parent | 3ce77655f026a316442f23d47da6c5cd89c1fdac (diff) | |
perf: replace strcpy() with strncpy() in util/jitdump.c
Usage of strcpy() can lead to buffer overflows. Therefore, it has been
replaced with strncpy(). The output file path is provided as a parameter
and might be restricted by command-line by default. But this defensive
patch will prevent any potential overflow, making the code more robust
against future changes in input handling.
Testing:
- ran perf test from tools/perf and did not observe any regression with
the earlier code
Signed-off-by: Hrishikesh Suresh <hrishikesh123s@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/util/jitdump.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/perf/util/jitdump.c b/tools/perf/util/jitdump.c index b062b1f234b6..496ca2d2bfdb 100644 --- a/tools/perf/util/jitdump.c +++ b/tools/perf/util/jitdump.c @@ -233,7 +233,8 @@ jit_open(struct jit_buf_desc *jd, const char *name) /* * keep dirname for generating files and mmap records */ - strcpy(jd->dir, name); + strncpy(jd->dir, name, PATH_MAX); + jd->dir[PATH_MAX - 1] = '\0'; dirname(jd->dir); free(buf); |