diff options
| -rw-r--r-- | drivers/media/i2c/adv7604.c | 8 | ||||
| -rw-r--r-- | drivers/media/i2c/et8ek8/et8ek8_driver.c | 4 |
2 files changed, 11 insertions, 1 deletions
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index 516553fb17e9..67116a4ef134 100644 --- a/drivers/media/i2c/adv7604.c +++ b/drivers/media/i2c/adv7604.c @@ -3453,7 +3453,13 @@ static int configure_regmaps(struct adv76xx_state *state) static void adv76xx_reset(struct adv76xx_state *state) { if (state->reset_gpio) { - /* ADV76XX can be reset by a low reset pulse of minimum 5 ms. */ + /* + * Note: Misinterpretation of reset assertion - do not re-use + * this code. The reset pin is using incorrect (for a reset + * signal) logical level. + * + * ADV76XX can be reset by a low reset pulse of minimum 5 ms. + */ gpiod_set_value_cansleep(state->reset_gpio, 0); usleep_range(5000, 10000); gpiod_set_value_cansleep(state->reset_gpio, 1); diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c b/drivers/media/i2c/et8ek8/et8ek8_driver.c index 2cb7b718782b..50121c3e5b48 100644 --- a/drivers/media/i2c/et8ek8/et8ek8_driver.c +++ b/drivers/media/i2c/et8ek8/et8ek8_driver.c @@ -835,6 +835,10 @@ static int et8ek8_power_on(struct et8ek8_sensor *sensor) udelay(10); /* I wish this is a good value */ + /* + * Note: Misinterpretation of reset assertion - do not re-use this code. + * The reset pin is using incorrect (for a reset signal) logical level. + */ gpiod_set_value(sensor->reset, 1); msleep(5000 * 1000 / sensor->xclk_freq + 1); /* Wait 5000 cycles */ |