diff options
| author | Andrew Goodbody <andrew.goodbody@linaro.org> | 2025-07-23 11:34:36 +0100 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2025-07-29 13:14:47 -0600 |
| commit | 0fdcca86d87b3b723cdfc9901f02f14adba9df60 (patch) | |
| tree | a8a312a83562abed749d4e4beb1054ebe081259f | |
| parent | 4b8aba93bdba168f284036cd7f8cb0e988bf3f92 (diff) | |
bios_emulator: Add parens to xorl macro
The xorl macro lacked surrounding parens which meant that it could have
unexpected results when used in expressions. Fix this by adding the
surrounding parens to make its use predictable.
This issue was found by Smatch.
Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
| -rw-r--r-- | drivers/bios_emulator/x86emu/ops2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/bios_emulator/x86emu/ops2.c b/drivers/bios_emulator/x86emu/ops2.c index 1ff27b2af95..29a166f7fe9 100644 --- a/drivers/bios_emulator/x86emu/ops2.c +++ b/drivers/bios_emulator/x86emu/ops2.c @@ -66,7 +66,7 @@ void x86emuOp2_illegal_op( END_OF_INSTR(); } -#define xorl(a,b) ((a) && !(b)) || (!(a) && (b)) +#define xorl(a, b) (((a) && !(b)) || (!(a) && (b))) /**************************************************************************** REMARKS: |