diff options
| author | Andre Przywara <andre.przywara@arm.com> | 2025-03-27 15:32:59 +0000 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2025-04-08 16:23:51 -0600 |
| commit | 26b2482f124ba831e40a44ea0cb093203fd8d747 (patch) | |
| tree | d0e2c9972007848148cef93ad14e0f15a4c3ce33 | |
| parent | 2938eb1e022d7e1de23d89f941bc07b0776a2549 (diff) | |
use proper fallthrough annotations
In some cases in the generic code, we were already using switch/case
fallthrough annotations comments, though in a way which might not be
understood by most compilers.
Replace two non-standard /* no break */ comments with our fallthrough;
statement-like macro, to make this visible to the compiler.
Also use this macro in place of an /* Fall through */ comment, to be
more consistent.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
| -rw-r--r-- | common/command.c | 2 | ||||
| -rw-r--r-- | lib/tiny-printf.c | 2 | ||||
| -rw-r--r-- | net/net.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/common/command.c b/common/command.c index 3f691399cbe..0f9dd06d72b 100644 --- a/common/command.c +++ b/common/command.c @@ -484,7 +484,7 @@ int cmd_get_data_size(const char *arg, int default_size) case 'q': if (MEM_SUPPORT_64BIT_DATA) return 8; - /* no break */ + fallthrough; default: return CMD_DATA_SIZE_ERR; } diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c index 0503c17341f..b8fc8355c4a 100644 --- a/lib/tiny-printf.c +++ b/lib/tiny-printf.c @@ -282,7 +282,7 @@ static int _vprintf(struct printf_info *info, const char *fmt, va_list va) break; } islong = true; - /* no break */ + fallthrough; case 'x': if (islong) { num = va_arg(va, unsigned long); diff --git a/net/net.c b/net/net.c index 1828f1cca36..5219367e391 100644 --- a/net/net.c +++ b/net/net.c @@ -1559,7 +1559,7 @@ common: puts("*** ERROR: `ipaddr' not set\n"); return 1; } - /* Fall through */ + fallthrough; #ifdef CONFIG_CMD_RARP case RARP: |