diff options
author | Vincent Stehlé <vincent.stehle@arm.com> | 2025-04-07 19:05:27 +0200 |
---|---|---|
committer | Michal Simek <michal.simek@amd.com> | 2025-04-16 13:42:06 +0200 |
commit | 282a6424488afb35dc557e7fb2004f9b81732b12 (patch) | |
tree | fdb6084a393199969c2d06987b2759da59fe4a4d | |
parent | d688b0c1bdfc172a2a91bcea91a2198e30329bb0 (diff) |
arm64: versal: fix dfu alt buffer clearing
The set_dfu_alt_info() function calls the ALLOC_CACHE_ALIGN_BUFFER()
macro to declare a `buf' variable pointer into an array allocated on the
stack. It then calls the memset() function to clear the useable portion
of the array using the idiomatic expression `sizeof(buf)'.
While this would indeed work fine for an array, in the present case we
end up clearing only the size of a pointer.
Fix this by specifying the explicit size `DFU_ALT_BUF_LEN' instead.
Fixes: 064c8978b44f ("arm64: versal: Enable capsule update (SD)")
Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
Cc: Michal Simek <michal.simek@amd.com>
Cc: Tom Rini <trini@konsulko.com>
Acked-by: Padmarao Begari <padmarao.begari@amd.com>
Link: https://lore.kernel.org/r/20250407170529.893307-4-vincent.stehle@arm.com
-rw-r--r-- | board/xilinx/versal/board.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/xilinx/versal/board.c b/board/xilinx/versal/board.c index 8ea9eee9a1f..f0ac3fbadb1 100644 --- a/board/xilinx/versal/board.c +++ b/board/xilinx/versal/board.c @@ -406,7 +406,7 @@ void configure_capsule_updates(void) ALLOC_CACHE_ALIGN_BUFFER(char, buf, DFU_ALT_BUF_LEN); - memset(buf, 0, sizeof(buf)); + memset(buf, 0, DFU_ALT_BUF_LEN); multiboot = env_get_hex("multiboot", multiboot); |