diff options
| author | Heinrich Schuchardt <heinrich.schuchardt@canonical.com> | 2024-11-16 21:08:22 +0100 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2024-11-18 19:10:56 -0600 |
| commit | 3d0da87cd4020f9e14a249c0e080341d668d9426 (patch) | |
| tree | 4f7f9f65de37738fa118659742f03c8c6f18e949 | |
| parent | deb9a07cf167f68184fe782047bfd77c238276cd (diff) | |
test: cmd/hash: check return value of ut_check_console_line
ut_check_console_line() does include an assert.
Pass the result to ut_assertok().
Addresses-Coverity-ID: 514958 Error handling issues
Fixes: 7dfafcd65ef3 ("test: unit test for hash command")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
| -rw-r--r-- | test/cmd/hash.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/test/cmd/hash.c b/test/cmd/hash.c index 2fcec9cadcd..296dd762b31 100644 --- a/test/cmd/hash.c +++ b/test/cmd/hash.c @@ -33,11 +33,13 @@ static int dm_test_cmd_hash_md5(struct unit_test_state *uts) strstr(uts->actual_str, "md5 for ")); ut_assert(strstr(uts->actual_str, "d41d8cd98f00b204e9800998ecf8427e")); - ut_check_console_line(uts, "d41d8cd98f00b204e9800998ecf8427e"); + ut_assertok(ut_check_console_line(uts, + "d41d8cd98f00b204e9800998ecf8427e")); if (!CONFIG_IS_ENABLED(HASH_VERIFY)) { ut_assert(run_command("hash -v sha256 $loadaddr 0 foo", 0)); - ut_check_console_line(uts, "hash - compute hash message digest"); + ut_assertok(ut_check_console_line( + uts, "hash - compute hash message digest")); return 0; } @@ -77,12 +79,13 @@ static int dm_test_cmd_hash_sha256(struct unit_test_state *uts) strstr(uts->actual_str, "sha256 for ")); ut_assert(strstr(uts->actual_str, "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855")); - ut_check_console_line(uts, - "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"); + ut_assertok(ut_check_console_line( + uts, "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855")); if (!CONFIG_IS_ENABLED(HASH_VERIFY)) { ut_assert(run_command("hash -v sha256 $loadaddr 0 foo", 0)); - ut_check_console_line(uts, "hash - compute hash message digest"); + ut_assertok(ut_check_console_line( + uts, "hash - compute hash message digest")); return 0; } |