diff options
| author | Andrew Goodbody <andrew.goodbody@linaro.org> | 2025-08-07 11:04:04 +0100 |
|---|---|---|
| committer | Michal Simek <michal.simek@amd.com> | 2025-08-25 16:20:47 +0200 |
| commit | 7aac8439445793baa9313a7d5139b77f968b2885 (patch) | |
| tree | 73d9b11485ad6e7b6af923c101285ef497a578b1 | |
| parent | 0d1c4fd514c13fbda3b3016cfa9ce00b01e42bf9 (diff) | |
pinctrl: zynqmp: Ensure ret is initialised
In zynqmp_pinctrl_prepare_func_groups if called with func->ngroups == 0
then ret will not be assigned to before its value is returned on exit.
Initialise ret to ensure it is always valid.
This issue was found by Smatch.
Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Link: https://lore.kernel.org/r/20250807-pinctrl_misc-v1-3-eeb564a1b032@linaro.org
Signed-off-by: Michal Simek <michal.simek@amd.com>
| -rw-r--r-- | drivers/pinctrl/pinctrl-zynqmp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pinctrl/pinctrl-zynqmp.c b/drivers/pinctrl/pinctrl-zynqmp.c index 6fa203a3b86..27dadbff8ca 100644 --- a/drivers/pinctrl/pinctrl-zynqmp.c +++ b/drivers/pinctrl/pinctrl-zynqmp.c @@ -204,7 +204,7 @@ static int zynqmp_pinctrl_prepare_func_groups(u32 fid, const char **fgroups; char name[MAX_GROUP_NAME_LEN]; u16 resp[NUM_GROUPS_PER_RESP] = {0}; - int ret, index, i; + int ret = 0, index, i; fgroups = kcalloc(func->ngroups, sizeof(*fgroups), GFP_KERNEL); if (!fgroups) |