diff options
| author | Jerome Forissier <jerome.forissier@linaro.org> | 2024-11-22 13:35:29 +0100 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2024-11-22 14:37:21 -0600 |
| commit | 8c95d84b39fc0886a4417c5ddefc2ea05217c0ac (patch) | |
| tree | 205ed2fa761ee940d75a5e5d7cc3afbfd1df669a | |
| parent | e92b5d0ddfbe95b0d6bf5277f06d00b1acfa0b83 (diff) | |
net: lwip: fix dhcp_loop()
The local variables ipstr, maskstr and gwstr in static function
dhcp_loop() cannot be pointers to read-only data, since they may be
written to in case the device index is > 0. Therefore make them char
arrays allocated on the stack.
Reported-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
| -rw-r--r-- | net/lwip/dhcp.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/lwip/dhcp.c b/net/lwip/dhcp.c index 23b56226921..bfc72ca6c57 100644 --- a/net/lwip/dhcp.c +++ b/net/lwip/dhcp.c @@ -27,9 +27,9 @@ static void call_lwip_dhcp_fine_tmr(void *ctx) static int dhcp_loop(struct udevice *udev) { - char *ipstr = "ipaddr\0\0"; - char *maskstr = "netmask\0\0"; - char *gwstr = "gatewayip\0\0"; + char ipstr[] = "ipaddr\0\0"; + char maskstr[] = "netmask\0\0"; + char gwstr[] = "gatewayip\0\0"; unsigned long start; struct netif *netif; struct dhcp *dhcp; |