diff options
| author | Christian Marangi <ansuelsmth@gmail.com> | 2024-10-01 14:24:34 +0200 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2024-10-10 16:02:20 -0600 |
| commit | 9e3d83301e4f34064e09376bb6f2e199f21411de (patch) | |
| tree | 6da6661691ae01bbf832256055c78e74e306bebc | |
| parent | 136b7b6d2e9837849732c6ade8f4bdaf870ed83a (diff) | |
led: toggle LED on initial SW blink
We currently init the LED OFF when SW blink is triggered when
on_state_change() is called. This can be problematic for very short
period as the ON/OFF blink might never trigger.
Toggle the LED (ON if OFF, OFF if ON) on initial SW blink to handle this
corner case and better display a LED blink from the user.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
| -rw-r--r-- | drivers/led/led_sw_blink.c | 17 |
1 files changed, 15 insertions, 2 deletions
diff --git a/drivers/led/led_sw_blink.c b/drivers/led/led_sw_blink.c index 9e36edbee47..06a43db340c 100644 --- a/drivers/led/led_sw_blink.c +++ b/drivers/led/led_sw_blink.c @@ -103,8 +103,21 @@ bool led_sw_on_state_change(struct udevice *dev, enum led_state_t state) return false; if (state == LEDST_BLINK) { - /* start blinking on next led_sw_blink() call */ - sw_blink->state = LED_SW_BLINK_ST_OFF; + struct led_ops *ops = led_get_ops(dev); + + /* + * toggle LED initially and start blinking on next + * led_sw_blink() call. + */ + switch (ops->get_state(dev)) { + case LEDST_ON: + ops->set_state(dev, LEDST_OFF); + sw_blink->state = LED_SW_BLINK_ST_OFF; + default: + ops->set_state(dev, LEDST_ON); + sw_blink->state = LED_SW_BLINK_ST_ON; + } + return true; } |