diff options
| author | Quentin Schulz <quentin.schulz@cherry.de> | 2025-05-28 14:07:27 +0200 |
|---|---|---|
| committer | Kever Yang <kever.yang@rock-chips.com> | 2025-06-06 17:23:34 +0800 |
| commit | b8101af3ce56a547f373d273d9ea37aefb74dc5a (patch) | |
| tree | e0777d1c19d7be993a27c15ffb5fc23fa738d67d | |
| parent | 210ab4f60df8d48abb475fd4dac7a9a74ffa6090 (diff) | |
power: rk8xx: fix swapped mask and value in init registers for RK806
The val (the bits to set) is the second member of the reg_data structure
and mask the third one. We obviously want to clear bits 6 and 7 in order
to only set bit 7 in there instead of only clearing bit 7 in order to
write bits 6 and 7 (which makes no sense).
Fortunately, according to the datasheet, bit 6 value doesn't matter when
bit 7 is set so this is essentially just a cosmetic change, no intended
change in behavior.
Fixes: f172575d92cd ("power: rk8xx: add support for RK806")
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
| -rw-r--r-- | drivers/power/pmic/rk8xx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/pmic/rk8xx.c b/drivers/power/pmic/rk8xx.c index a14555cf472..3bc696d4caa 100644 --- a/drivers/power/pmic/rk8xx.c +++ b/drivers/power/pmic/rk8xx.c @@ -91,7 +91,7 @@ void rk8xx_off_for_plugin(struct udevice *dev) static struct reg_data rk806_init_reg[] = { /* RST_FUN */ - { RK806_REG_SYS_CFG3, GENMASK(7, 6), BIT(7)}, + { RK806_REG_SYS_CFG3, BIT(7), GENMASK(7, 6)}, }; static struct reg_data rk817_init_reg[] = { |