diff options
| author | Vincent Stehlé <vincent.stehle@arm.com> | 2025-04-04 14:53:58 +0200 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2025-04-11 12:16:32 -0600 |
| commit | c4b273e441327f74449b3035d61ea92a077c1baa (patch) | |
| tree | 6d4b13a6690115f6a5755a1563caf3f42946d953 | |
| parent | ba13350d49370373bda42f9823d923adbee0e764 (diff) | |
cmd: optee: fix hello subcommand argument check
When the `optee hello' subcommand is called, the do_optee_hello_world_ta()
function passes a NULL pointer to the strcmp() function while verifying its
input argument, which results in the following crash:
=> optee hello
"Synchronous Abort" handler, esr 0x96000010, far 0x0
Fix this by verifying the number of input arguments instead.
Fixes: e3cf80fbe02d ("cmd: Add support for optee commands")
Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
Cc: Jens Wiklander <jens.wiklander@linaro.org>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Tom Rini <trini@konsulko.com>
Cc: Jerome Forissier <jerome.forissier@linaro.org>
Cc: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
| -rw-r--r-- | cmd/optee.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cmd/optee.c b/cmd/optee.c index d0d37293986..e3aae5e9f9b 100644 --- a/cmd/optee.c +++ b/cmd/optee.c @@ -53,7 +53,7 @@ static int do_optee_hello_world_ta(struct cmd_tbl *cmdtp, int flag, int argc, { int ret, value = 0; - if (strcmp(argv[1], NULL)) + if (argc > 1) value = hextoul(argv[1], NULL); ret = hello_world_ta(value); |