diff options
author | Jonas Karlman <jonas@kwiboo.se> | 2025-07-21 22:07:12 +0000 |
---|---|---|
committer | Kever Yang <kever.yang@rock-chips.com> | 2025-08-31 00:48:15 +0800 |
commit | dfd2774cfc4434ef35b48febcd1dc1860a3dc8f8 (patch) | |
tree | 66f1ddadf29ca9dde4f5b7b2c1d031c53c57bad6 | |
parent | 1e8370318f89b4a15d5ff9259363e44a852541b2 (diff) |
phy: rockchip: naneng-combphy: Fix Generic PHY reference counting
Generic PHY reference counting helps ensure driver ops for init/exit and
power on/off are called at correct state. For this to work the PHY
driver must initialize PHY-id to a persistent value in of_xlate ops.
The Rockchip COMBPHY driver does not initialize the PHY-id field, this
typically lead to use of unshared reference counting among different
struct phy instances.
Initialize the PHY-id in of_xlate ops to ensure use of shared reference
counting among all struct phy instances.
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
-rw-r--r-- | drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c index 6d8d10750b1..a66be0608d4 100644 --- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c +++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c @@ -224,6 +224,7 @@ static int rockchip_combphy_xlate(struct phy *phy, struct ofnode_phandle_args *a return -EINVAL; } + phy->id = priv->id; priv->mode = args->args[0]; return 0; |